feat: add warning for invalid precision in BN format method
#3586
+45
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning when precision is less than minPrecision in the BN.format method. This maintains backward compatibility while alerting users to potential issues. The warning suggests setting precision >= minPrecision for correct behavior. Resolves TODO in packages/math/src/bn.ts
VolodymyrBg
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk and
petertonysmith94
as code owners
|
Thanks for the contribution! Before we can merge this, we need @VolodymyrBg to sign the Fuel Labs Contributor License Agreement. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@VolodymyrBg is attempting to deploy a commit to the Fuel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey @VolodymyrBg 👋🏼 Could you add some tests around this behaviour? This PR also requires a changeset, run the following command and select the affected packages. pnpm changeset add |
|
@petertonysmith94 Done |
arboleya
changed the title
BN format method
arboleya
reviewed
Jan 16, 2025
danielbate
reviewed
Jan 17, 2025
Co-authored-by: Daniel Bate <[email protected]>
|
@danielbate Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning when precision is less than minPrecision in the BN.format method. This maintains backward compatibility while alerting users to potential issues. The warning suggests setting precision >= minPrecision for correct behavior.
Resolves TODO in packages/math/src/bn.ts
Checklist