Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the platform condition cmp #275

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yinfangchen
Copy link

When running on my Ubuntu, the update_tt_dp_cm and update_tt_sw_dp_cm will always go to the true branch ("Darwin" branch for MacOS) since there are missing spaces for besides the equal sign, so errors will pop up:

Start deployment Step <3/3>: train-ticket services--------------------------------------------
Start to deploy secret of train-ticket services.
Deploying service configurations...
Deploying train-ticket deployments...
sed: can't read s/nacos/nacos/g: No such file or directory
sed: can't read s/rabbitmq/rabbitmq/g: No such file or directory

The sed will regard the expression as a file path.

It will be safer to write in my way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant