adding join button #249
Open
adding join button #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Vishal-raj-1 hello sir i know last time you mentioned some changes in this PR thanks. |
Vishal-raj-1
requested changes
Oct 31, 2023
content/batch/index.mdx
Outdated
| <p>Learn HTML, CSS, JS and Git & Github</p> | ||
| <div className="flex-grow"></div> | ||
| <div className="text-center mt-4"> | ||
| <a href="/join/learn" className="rounded-full px-4 py-2" style={{ textAlign: 'center', color: 'black', backgroundColor: 'white', borderRadius: '18px', fontSize: '16px', width: 'fit-content', margin: '0 auto', padding: '8px 16px' }}>Join</a> |
There was a problem hiding this comment.
create a style object and use that. copy pasting same style every place is not a good practice
|
@Vishal-raj-1 sir, i make all the changes but there are some deployement issue thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Closes #184
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers