Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to install klippain-shaketune in a given directory. #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tsk-2222
Copy link

@tsk-2222 tsk-2222 commented Mar 5, 2024

Based on @arcadien's work on klippain. Thanks arcadien!

example: ./install.sh voron_2 or ./install.sh printer_8

Additionally, this needs an override or to be handled somehow:

[gcode_shell_command shaketune]
command: ~/printer_data/config/scripts/K-ShakeTune/shaketune.sh

If this script is acceptable, I also have the changes for klippain that are very similar.

@Frix-x Frix-x changed the base branch from develop to main April 29, 2024 16:28
@tsk-2222
Copy link
Author

I was hoping to get suggestions on how best to handle the lines below. These lines exist in shaketune.cfg and things will break if klippain is installed to ~/printer_8, etc.

[gcode_shell_command shaketune]
command: ~/printer_data/config/scripts/K-ShakeTune/shaketune.sh

It seems to me that an automatically populated entry in overrides.cfg would fix things. Any objections or better ideas?

@Frix-x
Copy link
Owner

Frix-x commented May 24, 2024

Hello,

Sorry for the silence here, in fact I haven't replied yet as there has been a major rework for Shake&Tune that is almost finished now. You can find it in the development branch: it's now a fully integrated Klipper plugin.

So basically this is much easier for the install script, which now just symlinks files into the Klipper extras folder and installs the requirements into the klipper python venv. Then users just need to add [shaketune] to their config.

So I think your PR will need to be changed a bit to account for multi-klipper in this new way of installation, but it should be much easier in the end as there's no need for gcode_shell commands anymore... :)

@Frix-x Frix-x added the enhancement New feature or request label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants