Add compression checker for cart and cache #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-arcus
force-pushed
the
add-compression-checker
branch
from
7859b01
to
8baca67
Compare
|
No idea why the PHP Stan check fails, the config parameter is the correct one according to the documentation. Should I switch to a runtime config parameter check? |
|
The pipeline installs 6.6.0.0, I would recommand creating a compiler pass (or extending existing one), when the parameter is not there, set it to false. So the parameter exists in every version |
shyim
reviewed
Sep 1, 2024
M-arcus
force-pushed
the
add-compression-checker
branch
2 times, most recently
from
138a921
to
d92971f
Compare
M-arcus
force-pushed
the
add-compression-checker
branch
from
d92971f
to
fdf4ed7
Compare
shyim
reviewed
Sep 1, 2024
src/Components/Health/Checker/PerformanceChecker/AbstractCompressionChecker.php
Outdated
Show resolved
Hide resolved
M-arcus
force-pushed
the
add-compression-checker
branch
from
9dd3c26
to
398ace5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.