Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL Settings: Check performance settings #268

Merged
merged 2 commits into from
Aug 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
<?php

declare(strict_types=1);

namespace Frosh\Tools\Components\Health\Checker\PerformanceChecker;

use Doctrine\DBAL\Connection;
use Frosh\Tools\Components\Health\Checker\CheckerInterface;
use Frosh\Tools\Components\Health\HealthCollection;
use Frosh\Tools\Components\Health\SettingsResult;
use Shopware\Core\DevOps\Environment\EnvironmentHelper;

class MysqlSettingsChecker implements PerformanceCheckerInterface, CheckerInterface
{
public const MYSQL_GROUP_CONCAT_MAX_LEN = 320000;

public const MYSQL_SQL_MODE_PART = 'ONLY_FULL_GROUP_BY';

public function __construct(private readonly Connection $connection) {}

public function collect(HealthCollection $collection): void
{
$url = 'https://developer.shopware.com/docs/guides/hosting/performance/performance-tweaks.html#mysql-configuration';
shyim marked this conversation as resolved.
Show resolved Hide resolved
$this->checkGroupConcatMaxLen($collection, $url);
$this->checkSqlMode($collection, $url);
$this->checkCheckDefaultEnvironmentSessionVariables($collection, $url);
}

private function checkGroupConcatMaxLen(HealthCollection $collection, string $url): void
{
/** @var string|false $groupConcatMaxLen */
$groupConcatMaxLen = $this->connection->fetchOne('SELECT @@group_concat_max_len');
if (!$groupConcatMaxLen || (int) $groupConcatMaxLen < self::MYSQL_GROUP_CONCAT_MAX_LEN) {
$collection->add(
SettingsResult::error(
'sql_group_concat_max_len',
'MySQL value group_concat_max_len',
(string) $groupConcatMaxLen,
'Atleast ' . self::MYSQL_GROUP_CONCAT_MAX_LEN,
$url,
),
);
}
}

private function checkSqlMode(HealthCollection $collection, string $url): void
{
/** @var string|false $sqlMode */
$sqlMode = $this->connection->fetchOne('SELECT @@sql_mode');
if (!$sqlMode || !str_contains($sqlMode, self::MYSQL_SQL_MODE_PART)) {
$collection->add(
SettingsResult::error(
'sql_mode',
'MySQL value sql_mode',
(string) $sqlMode,
'Contains ' . self::MYSQL_SQL_MODE_PART,
$url,
),
);
}
}

private function checkCheckDefaultEnvironmentSessionVariables(HealthCollection $collection, string $url): void
{
$setSessionVariables = (bool) EnvironmentHelper::getVariable('SQL_SET_DEFAULT_SESSION_VARIABLES', true);
if ($setSessionVariables) {
$collection->add(
SettingsResult::warning(
'sql_set_default_session_variables',
'MySQL session vars are set on each connect',
'enabled',
'disabled',
$url,
),
);
}
}
}