-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add Shopmon ACL role #251
Feature: add Shopmon ACL role #251
Conversation
To discuss:
Edit: |
|
||
protected function configure(): void | ||
{ | ||
$this->addOption('username', null, InputOption::VALUE_OPTIONAL, 'User that will be assigned the role'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why a user, we should only create a integration? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user:create command in core doesn't support ACL/roles
so in a CI/CD setup first create a shopmon user with user:create and create+assign the role with this command
I like the idea, but I think we should more to bring Shopmon as an app into the Store. First, for visibility, and second, we can request easily more permissions in the future. https://github.com/FriendsOfShopware/shopmon/blob/main/app/manifest.xml |
I will close this PR. If anyone needs this, I've made a separate plugin https://github.com/MelvinAchterhuis/MelvShopmonIntegration |
#158