Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Shopmon ACL role #251

Closed
wants to merge 3 commits into from
Closed

Feature: add Shopmon ACL role #251

wants to merge 3 commits into from

Conversation

MelvinAchterhuis
Copy link
Member

@MelvinAchterhuis
Copy link
Member Author

MelvinAchterhuis commented Feb 23, 2024

To discuss:

  • Currently there is a check on the name of the role to determine if the role exists, maybe use a fixed UUID?
  • How to maintain when Shopmon needs more permissions?

Edit:
UUID has been added, perhaps we can use this in the future when Shopmon needs more permissions?


protected function configure(): void
{
$this->addOption('username', null, InputOption::VALUE_OPTIONAL, 'User that will be assigned the role');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a user, we should only create a integration? 🤔

Copy link
Member Author

@MelvinAchterhuis MelvinAchterhuis Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user:create command in core doesn't support ACL/roles

so in a CI/CD setup first create a shopmon user with user:create and create+assign the role with this command

@shyim
Copy link
Member

shyim commented Feb 23, 2024

I like the idea, but I think we should more to bring Shopmon as an app into the Store. First, for visibility, and second, we can request easily more permissions in the future. https://github.com/FriendsOfShopware/shopmon/blob/main/app/manifest.xml

@MelvinAchterhuis
Copy link
Member Author

I like the idea, but I think we should more to bring Shopmon as an app into the Store. First, for visibility, and second, we can request easily more permissions in the future. https://github.com/FriendsOfShopware/shopmon/blob/main/app/manifest.xml

I will close this PR. If anyone needs this, I've made a separate plugin https://github.com/MelvinAchterhuis/MelvShopmonIntegration

@shyim shyim mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants