Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add info about Security updates for installed version #247

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: add info about Security updates for installed version #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
194 changes: 165 additions & 29 deletions src/Components/Health/Checker/HealthChecker/SwagSecurityChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,35 +30,8 @@ public function collect(HealthCollection $collection): void
{
$this->refreshPlugins($this->connection);

try {
if (!$this->hasSecurityAdvisories()) {
return;
}
} catch (\Throwable) {
$collection->add(
SettingsResult::error(
'security-update',
'Cannot check security.json from shopware-static-data',
'not accessible',
'accessible',
'https://raw.githubusercontent.com/FriendsOfShopware/shopware-static-data/main/data/security.json'
)
);
}

if ($this->swagSecurityInstalled()) {
return;
}

$collection->add(
SettingsResult::error(
'security-update',
'Security update',
'Shopware outdated',
'Update Shopware to the latest version or install recent version of the plugin SwagPlatformSecurity',
'https://store.shopware.com/en/swag136939272659f/shopware-6-security-plugin.html'
)
);
$this->determineSecurityIssue($collection);
$this->determineEolSupport($collection);
}

private function refreshPlugins(Connection $connection): void
Expand Down Expand Up @@ -110,4 +83,167 @@ private function swagSecurityInstalled(): bool

return !empty($result);
}

private function determineSecurityIssue(HealthCollection $collection): void
{
try {
if (!$this->hasSecurityAdvisories()) {
return;
}
} catch (\Throwable) {
$collection->add(
SettingsResult::error(
'security-update',
'Cannot check security.json from shopware-static-data',
'not accessible',
'accessible',
'https://raw.githubusercontent.com/FriendsOfShopware/shopware-static-data/main/data/security.json'
)
);
}

if ($this->swagSecurityInstalled()) {
return;
}

$collection->add(
SettingsResult::error(
'security-update',
'Security update',
'Shopware outdated',
'Update Shopware to the latest version or install recent version of the plugin SwagPlatformSecurity',
'https://store.shopware.com/en/swag136939272659f/shopware-6-security-plugin.html'
)
);
}

private function determineEolSupport(HealthCollection $collection): void
{

$id = 'security-eol-shopware';
$snippet = 'Security updates';

try {
$releaseSupport = $this->getReleasesSupport();
} catch (\Throwable) {
$collection->add(
SettingsResult::error(
$id,
$snippet,
'releases.json not accessible',
'accessible',
'https://raw.githubusercontent.com/shopware/shopware/trunk/releases.json'
)
);

return;
}

$recommended = 'Please update to a more recent version and minimum LTS version ' . ($releaseSupport['extended_eol_version'] ?? 'unknown') . '.';

if (empty($releaseSupport['security_eol'])) {
$collection->add(
SettingsResult::error(
$id,
$snippet,
'unknown, possibly ended security support',
$recommended
)
);

return;
}

$securityEol = new \DateTime($releaseSupport['security_eol']);

if ($securityEol < (new \DateTime())) {
$collection->add(
SettingsResult::error(
$id,
$snippet,
'ended security support on ' . $releaseSupport['security_eol'],
$recommended
)
);

return;
}

if ($securityEol < (new \DateTime())->modify('+6 month')) {
$collection->add(
SettingsResult::warning(
$id,
$snippet,
'less than six months (' . $releaseSupport['security_eol'] . ')',
$recommended
)
);

return;
}

if ($securityEol < (new \DateTime())->modify('+1 year')) {
$collection->add(
SettingsResult::info(
$id,
$snippet,
'less than one year (' . $releaseSupport['security_eol'] . ')',
$recommended
)
);

return;
}

$collection->add(
SettingsResult::ok(
$id,
$snippet,
'until ' . $releaseSupport['security_eol']
)
);
}

/**
* @return array{version?: string, release_date?: string, extended_eol?: string|false, security_eol?: string, extended_eol_version?: string}
*/
private function getReleasesSupport(): array
{
$cacheKey = \sprintf('shopware-releases-support-%s', $this->shopwareVersion);

return $this->cacheObject->get($cacheKey, function (ItemInterface $cacheItem) {
$releasesJson = file_get_contents('https://raw.githubusercontent.com/shopware/shopware/trunk/releases.json');
if ($releasesJson === false) {
throw new \RuntimeException('Could not fetch releases.json');
}

$data = \json_decode(trim($releasesJson), true, 512, JSON_THROW_ON_ERROR);

if (!\is_array($data)) {
throw new \RuntimeException('Could not read releases.json');
}

$cacheItem->expiresAfter(3600 * 24 * 14);

$result = [];

foreach ($data as $entry) {
if (empty($entry['version'])) {
continue;
}

if (!empty($entry['extended_eol'])
&& version_compare($entry['version'], ($result['extended_eol_version'] ?? ''), '>')) {
$result['extended_eol_version'] = $entry['version'];
}

if (version_compare($entry['version'], ($result['version'] ?? ''), '>')
&& version_compare($entry['version'], $this->shopwareVersion, '<=')) {
$result = [...$result, ...$entry];
}
}

return $result;
});
}
}
Loading