fix(database/influxdb): replace invisible chars and whitespaces with space #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grische
changed the title
corny
requested changes
May 28, 2024
| // https://docs.influxdata.com/influxdb/v2/reference/syntax/line-protocol/ | ||
| // Line protocol does not support the newline character \n in tag or field values. | ||
| // To be safe, remove all non-printable characters and spaces except ASCII space and U+0020. | ||
| for _, tag := range tags { |
There was a problem hiding this comment.
Please move this loop into a new function
grische
force-pushed
the
fix/influxdb-linebreak-error
branch
from
4e60c98 to
8de9029
Compare
This fixes issues where users use '\n' in tag values (e.g. the owner) that is incompatible with InfluxDB's Line protocol.
grische
force-pushed
the
fix/influxdb-linebreak-error
branch
from
8de9029 to
e87b23e
Compare
genofire
changed the title
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sanitize tag values before they are being sent to Influx.
This fixes issues where users use '\n' in tag values (e.g. the owner) that is incompatible with InfluxDB's Line protocol.'
Thanks a lot for @T0biii for the help in tracing this error and creating a solution!
Motivation and Context
We keep on seeing errors in the yanic log about
Because the user uses
peter@hase\n.deas their owner name. This works in other parts of yanic, but causes issues with influx.Checklist: