Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARP/ND Build Separation #1175

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

HTRamsey
Copy link
Contributor

@HTRamsey HTRamsey commented Aug 1, 2024

Full separation of ND & ARP for better ipv4/ipv6 configuration
Separate config macros because ARP/ND have different defaults

@HTRamsey
Copy link
Contributor Author

HTRamsey commented Aug 3, 2024

/bot run formatting

@HTRamsey HTRamsey force-pushed the dev-ip-build-sep branch 6 times, most recently from 29a9002 to 08ed9d5 Compare August 25, 2024 23:54
@HTRamsey HTRamsey marked this pull request as ready for review August 26, 2024 00:17
@HTRamsey HTRamsey requested a review from a team as a code owner August 26, 2024 00:17
@moninom1
Copy link
Member

moninom1 commented Aug 27, 2024

Hi @HTRamsey , Thank you for this PR, we will review it internally.
Can you also please let us know the plan to fix Unit tests and CBMC failures. Thanks

@HTRamsey
Copy link
Contributor Author

HTRamsey commented Aug 27, 2024

Probably by the end of the week. It's mostly just name changes & moving stuff so it should be easy to fix

@HTRamsey
Copy link
Contributor Author

Whenever I give a time estimation I guess just double or triple it

@HTRamsey
Copy link
Contributor Author

/bot run formatting

@HTRamsey
Copy link
Contributor Author

@ActoryOu & @moninom1 I may need some assistance on this last part as I don't know much about cbmc

@ActoryOu
Copy link
Member

ActoryOu commented Oct 1, 2024

@ActoryOu & @moninom1 I may need some assistance on this last part as I don't know much about cbmc

Hi @HTRamsey,
I'll take a look on this and it might take some time addressing this.
Thank you for notification!

source/FreeRTOS_IP.c Show resolved Hide resolved
test.sh Outdated Show resolved Hide resolved
@ActoryOu
Copy link
Member

Hi @HTRamsey,
Sorry for late response. I finially find some time fixing the UT/CBMC issues.
Please help take a look when you're available to check if any change is unexpected.

Thank you.

@HTRamsey
Copy link
Contributor Author

@ActoryOu looks good as far as I can tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants