Date sorting now works #174
Conversation
…g; also separate workflkow card construction from filtering
| dat <- Filter(\(w) { | ||
| w$data$status %in% input$workStatus | ||
| }, dat) | ||
| } | ||
| # Filter by workflow name | ||
| if (nzchar(input$workName)) { | ||
| dat <- Filter(\(w) { | ||
| w$data$workflow_name == input$workName | ||
| w$data$workflow_name %in% input$workName |
There was a problem hiding this comment.
Am I understanding right that this addresses #112?
There was a problem hiding this comment.
No. The %in% operator just changes behavior so that input$workName can be a vector instead of a string with ==. It works for now, but it's not needed for the current input$workName, because the input is a single string. I think this is leftover from when I was testing the many inputs style box where the user could put in > 1 workflow name. I'll undo this change to make it more clear
|
@sckott -- Date sorting works great! It appears that we're now limiting people to 4 months of job history, which isn't necessarily a bad thing, just curious of the rationale. Is that for app responsiveness purposes? Wondering if (in the future, not now) we can allow for longer date ranges, but just default to 4 months. Also with respect to my earlier comment, if that line was intended to address #112, it doesn't appear to be working, but I might be misreading the purpose of that code change.. |
Before this PR we were at two months. And before this switchover to bsilb Amy had set it at a max of I think 21 days. Anywho, yeah I think more history is better too. Of course we I'm sure would run into performance issues with the app if there was too mjuch data - I don't know how much too much would be. Should I try 1 year and see how that goes? |
fix #173