Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear/reset ui outputs in workflow details page #171

Merged
merged 2 commits into from
Nov 7, 2024
Merged

clear/reset ui outputs in workflow details page #171

merged 2 commits into from
Nov 7, 2024

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Nov 1, 2024

fix #164

  • add ids to each of the workflow details tabs
  • change most workflow details tab outputs away from renderUI/uiOutput
  • above change speeds up app UI rendering & makes it easier to update new data as needed
  • reset all Workflow Details buttons on each card after navigating to the deets page

@sckott
fix #164 clear/reset ui outputs in workflow details page
654e8b2 
- add ids to each of the workflow details tabs
- change most workflow details tab outputs away from renderUI/uiOutput
- above change speeds up app UI rendering & makes it easier to update new data as needed
- reset all Workflow Details buttons on each card after navigating to the deets page
@sckott sckott requested a review from tefirman November 1, 2024 19:59
@sckott sckott mentioned this pull request Nov 1, 2024
Open
@sckott sckott added the v1.2 Should be implemented in PROOF v1.2 label Nov 1, 2024
tefirman
tefirman approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, merging to dev and testing in proof-dev.fredhutch.org, will report back. Thanks @sckott !!

@tefirman tefirman merged commit 7335ef6 into dev Nov 7, 2024
1 check passed
@tefirman
Copy link
Collaborator

tefirman commented Nov 7, 2024 •
edited
Loading

Previously, I noticed that the app would cut back to "Workflow Details" after clicking "Refresh Data" if you had already selected a workflow to analyze. Looks like this update fixes that, which is awesome!

"Workflow Details" tab seems to be working great (and really fast!), but is there anything else in particular I should be looking for in terms of testing?

@tefirman tefirman mentioned this pull request Nov 7, 2024
Draft
@tefirman tefirman deleted the clear-old-details-data branch November 7, 2024 23:34
@sckott
Copy link
Collaborator Author

sckott commented Nov 8, 2024

@tefirman

is there anything else in particular I should be looking for in terms of testing?

yes, the problem this PR was trying to solve was that some tabs on Workflow Details had old data from a previous workflow ID. This PR was trying to make sure that if a user clicks workflow A details button, then they clcik details button for a different workflow (workflow B) when they get to the details page the data is all for workflow B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tefirman tefirman tefirman approved these changes

Assignees
No one assigned
Labels
v1.2 Should be implemented in PROOF v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sckott @tefirman