Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI changes based on sonu user studies #162

Merged
merged 23 commits into from
Oct 30, 2024
Merged

UI changes based on sonu user studies #162

merged 23 commits into from
Oct 30, 2024

Conversation

sckott
Copy link
Collaborator

@sckott sckott commented Oct 25, 2024 •
edited
Loading

You can run this by doing:

make branch=ui-changes run_branch

related issues:

#154
#155
#156
#157
#158
#159
#160

@sckott
fix #154 navbar changes
b962c51 
- add logo in upper left
- black navbar
- click proof to get to landing page
- resources tab name change and placement
@sckott
fix #155 change "this" to proof and what the acronym means
8f69367
@sckott
#156 changed headings on help page and added email and open an issue …
1742199 
…lines
@sckott
fix #156 - add back code last date change, commit sha and link to repo
127263c
@sckott
#157 server page: make Notes consistent, use bootstrap alerts for the…
833ba35 
…m all
@sckott
fix #157 add spinner for loading server details on server page
108b116
@sckott
#158 submit pages changes:
50e8ae3 
- make submit button green when enabled
- disbale submit button until a wdl is uploaded (other files are optional so arent related to disabled state)
- move submission result under submit button
- unrelated: disable start server button on server page when status is running
@sckott
undo addition of server spinner in 108b116 for now, need to refine it…
95cb8bd 
… more
@sckott
#159 track workflow page: each card
0278065 
- move workflow id to bottom left of card
- move name and labels to top left of card
@sckott
#159 added spinner for workflow details buttons on each click, and re…
57064c2 
…set after loading details page is done, removed icon
@sckott
possible fix for 401 error
0e1a4d0
@sckott
change server start disable toggle - run toggle only if logged in and…
1392c9c 
… server up
@sckott
move cromwellProofStatusData call in proofStatusTextGenerator within …
c3f5439 
…if logged in block
@sckott
fix #159 add spinner loading to cards on tracking page
1e5af36
@sckott
#158 submit page, disable submit button on page load, and disable but…
37ac9a6 
…ton after result returned
@sckott
#160 move troubleshoot tab into workflow details tab
a80d551
@sckott
clean up workflow details page to have each panel be its own R object
92c3de9
@sckott
#160 rework header of workflow details, name and labels on left, ID o…
d03bdba 
…n right
@sckott
#160 workflow details work
c3606d1 
- add spinners to most tabs in workflow details tab
- add alert to workflow options tab when theres no data to show
- clean up some code
@sckott
code cleanup, remove an old file, and remove focus_id stuff
6115cc0
@sckott sckott mentioned this pull request Oct 29, 2024
Draft
@sckott sckott marked this pull request as ready for review October 29, 2024 15:19
@sckott
Copy link
Collaborator Author

sckott commented Oct 29, 2024

@codebeaker changes in 8a03d23

tefirman
tefirman approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tefirman tefirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks for updating these!!

@tefirman tefirman merged commit 5197a40 into dev Oct 30, 2024
1 check passed
@tefirman tefirman deleted the ui-changes branch November 7, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tefirman tefirman tefirman approved these changes

@codebeaker codebeaker Awaiting requested review from codebeaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sckott @tefirman