Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear workflow details outputs before the app switches to the details tab #164

Open
sckott opened this issue Oct 29, 2024 · 1 comment · May be fixed by #163
Open

Clear workflow details outputs before the app switches to the details tab #164

sckott opened this issue Oct 29, 2024 · 1 comment · May be fixed by #163
Labels
high priority Important and critical, fix/implement ASAP v1.2 Should be implemented in PROOF v1.2

Comments

@sckott
Copy link
Collaborator

sckott commented Oct 29, 2024

clear any outputs on workflow details tabs before the app switches to the details tabs so that data for a previous workflow doesn't get confused with the new one the user is looking at

right now they are not cleared and it is no bueno
@sckott
Copy link
Collaborator Author

sckott commented Oct 29, 2024

@tefirman this is pretty important

@sckott sckott added v1.2 Should be implemented in PROOF v1.2 high priority Important and critical, fix/implement ASAP labels Oct 29, 2024
sckott added a commit that referenced this issue Nov 1, 2024
@sckott
fix #164 clear/reset ui outputs in workflow details page
654e8b2 
- add ids to each of the workflow details tabs
- change most workflow details tab outputs away from renderUI/uiOutput
- above change speeds up app UI rendering & makes it easier to update new data as needed
- reset all Workflow Details buttons on each card after navigating to the deets page
@sckott sckott mentioned this issue Nov 1, 2024
Merged
@tefirman tefirman linked a pull request Nov 7, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority Important and critical, fix/implement ASAP v1.2 Should be implemented in PROOF v1.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shiny-cromwell v1.2.0 Updates FredHutch/shiny-cromwell
1 participant
@sckott