Cleanups for FlexRay tests #612
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rumpelsepp
commented
Oct 24, 2024
•
rumpelsepp
commented
- chore: Remove nix files
- refactor: Unroll variable creation and call to .append()
- fix(db): Handle CancelledError in database tasks
- feat(fr): Handle FlowControl messages for large messages
- fix(fr): Add a timeout for reading consecutive frames
`uv` changes all this and it is not needed any more.
rumpelsepp
force-pushed
the
cleanups
branch
4 times, most recently
from
711e2ff
to
ee5a8b7
Compare
I was not smart enough to understand this code. Unroll it! :)
Co-authored-by: Tobias Specht <[email protected]>
Co-authored-by: Tobias Specht <[email protected]>
It is not clear which timeout makes sense. This is a educated guess, that needs to be refined in the future… Co-authored-by: Stefan Tatschner <[email protected]>
peckto
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.