chore: Migrate to new context manager asyncio.timeout() #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpelsepp
changed the title
|
What exactly is the added benefit or the fixed bug of this change? |
ferdinandjarisch
requested changes
Jul 19, 2024
Code consistency. This is the recommended way of doing async timeouts nowadays: https://docs.python.org/3/library/asyncio-task.html#timeouts. I started to use this new API in #555 which would introduce a new way of doing things. For the sake of consistency I did this migration. IMO it is important to stay syncronized with how the community does things to keep the codebase evolving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.