Update ANTLR grammar and make it fuzzy #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably got lost when merging our previous fuzzy grammar with the latest Solidity Antlr gammar.
konradweiss
approved these changes
Nov 30, 2023
konradweiss
reviewed
Nov 30, 2023
| @@ -13,11 +20,12 @@ sourceUnit | |||
| | contractDefinition | |||
| | enumDefinition | |||
| | structDefinition | |||
| | contractPart | |||
There was a problem hiding this comment.
@fwendland does this not mean that eventDefinition modifierDefinition and customErrorDefinition can no longer appear in a snippet outside of a contract and while stateVariableDeclaration can still appear it is not inside of the ()* clause and can therefore not appear in multiples?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest ANTLR grammar from solidity-parser and make it fuzzy by allowing: