Adding Findsym, Method 4 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_sym(cif, outfname) takes a specified cif and returns a symmetrised version
New isodistort.py -> replaces isoget.py Adds method 4 functionality Rename get -> getMethod3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findsym: get_sym(cif, outfname) returns a symmetrised version of the input cif
New isodistort.py file -> should replace isoget
Contains method 3 -> get renamed to getMethod3, same arguments as before
format checking moved to a separate function
getMethod4(parentcif, subcif, outfname, specify, basis, format, var_dict)
-> gets distortions from parentcif to subcif
-> default - automatic basis detection, basis = []
-> can specify basis by setting specify to True and defining the basis