Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate prod database #992

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Migrate prod database #992

wants to merge 7 commits into from

Conversation

GeoffreyHuck
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (60c4ecb) 100.00% compared to head (149f733) 100.00%.
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #992   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          230       230           
  Lines        13870     13870           
=========================================
  Hits         13870     13870           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check what fails in the test? It seems to be a legitimate error, so probably there is something to fix (otherwise, the next PR containing migrations will fail as well I think)

@@ -0,0 +1,15 @@
-- +migrate Up

ALTER TABLE `groups_login_prefixes` DROP COLUMN `idUserCreator`;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the line that makes the migration fail

@GeoffreyHuck
Copy link
Contributor Author

I annoted the line with the migration problem here: https://github.com/France-ioi/AlgoreaBackend/pull/992/files

It looks like the database used doesn't have the same schema as the one used to write the migrations.

@GeoffreyHuck GeoffreyHuck requested a review from smadbe September 7, 2023 06:10
@smadbe
Copy link
Contributor

smadbe commented Sep 7, 2023

Ok, but at the end we have to do something to prevent this error to raise each time we write a migration from now. Either fix the db seed and fix the migration file.

Copy link
Contributor

@smadbe smadbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is not waiting for my review anymore I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants