-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate prod database #992
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 230 230
Lines 13870 13870
=========================================
Hits 13870 13870 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you check what fails in the test? It seems to be a legitimate error, so probably there is something to fix (otherwise, the next PR containing migrations will fail as well I think)
d84a9e7
to
87b776f
Compare
@@ -0,0 +1,15 @@ | |||
-- +migrate Up | |||
|
|||
ALTER TABLE `groups_login_prefixes` DROP COLUMN `idUserCreator`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the line that makes the migration fail
I annoted the line with the migration problem here: https://github.com/France-ioi/AlgoreaBackend/pull/992/files It looks like the database used doesn't have the same schema as the one used to write the migrations. |
Ok, but at the end we have to do something to prevent this error to raise each time we write a migration from now. Either fix the db seed and fix the migration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is not waiting for my review anymore I think.
groups
.sPassword