refreshToken: put the lock before the most recent token is retrieved
#1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eved, because if another refresh is already happening, the most recent token will have changed when the lock is released. The following process had an issue: 1. We start two refresh requests 2. The first one takes the lock and refresh the token, while the second gets the most recent token of the session, then waits for the lock 3. The first request finishes, put the new token in the database, and release the lock 4. The second request refreshes the token. But it shouldn't, because now there is a valid most recent token for the session! With this change, 4. becomes: The second request get the most recent valid token for the session, notices it is too new to refresh, and simply returns it. Signed-off-by: Geoffrey Huck <[email protected]>
smadbe
approved these changes
Jun 17, 2024
|
@zenovich could you take over this PR (i.e. check it and add the required tests)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If another refresh is already happening, the most recent token will have changed when the lock is released, and with the current code, it will be refreshed again.
The following process had an issue:
With this change, 4. becomes: The second request acquires the lock, gets the most recent valid token for the session, notices it is too new to refresh, and simply returns it.
Note: maybe we need a test for that.