-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial PartCAD packages and assembly files #240
Open
openvmp
wants to merge
25
commits into
FourThievesVinegar:main
Choose a base branch
from
openvmp:feature/partcad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontrol unit are added for now.
… public repository
Added screws attaching lid to the control box
Added parts: pumps box with the lid, temperature exchange units' lids
Refactoring of hierarchy + ReactorUnit/PumpsBox
Mostly finished reactor unit (without stirring mechanism)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is the first step toward using PartCAD for parameterized mechanical parts and assembly management.
Only some parts of the control unit are added for now.
It demonstrates how assemblies can be created.
What
What is affected by this PR?
Testing
How was this tested?
The only functional impact so far is that some documentation can be rendered.
While rendering the documentation, some inconsistencies in the published part files were identified.
Notes
This PR does not change anything for the users of Microlab yet.
It's just the foundation that allows building a process for ease of manufacturing and procurement of parts for the parametric design.