Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combat rifle loot list and type 93 addition #493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JustLoveBeingAnOwl
Copy link
Contributor

@JustLoveBeingAnOwl JustLoveBeingAnOwl commented Apr 4, 2024

Adds the combat rifle to tier 3 loot lists and mid loot lists as well as the type 93 to the latter

About The Pull Request

This adds the Fallout 4 combat rifle to tier 3 and "mid"-tier loot lists because I like the FO4 combat rifle and it doesn't deserve to be collecting dust much like how I added back the Type 93 to loot lists.

I also blundered and only added the Type 93 to one type of lootlist tiers (the numerical one) in my previous PR that did so. I adjusted the f13lootdrop file so that the worn type 93s should now spawn as much as m1 garands, marksman carbines, etc would.

Why It's Good For The Game

Variety to loot lists and it adds a gun from a mainline Fallout game (Fallout 4) and makes the Worn Type 93 spawn a little more often (and sometimes in the merchant's store.)

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

Changelog

🆑
add: combat rifle to Tier 3 and "mid" loot lists.
tweak: Worn Type 93 to "mid loot lists", already in tier 3 lootlists
/:cl:

Adds the combat rifle to tier 3 loot lists and mid lootlists as well as the type 93 to the latter
@CVSthePharmacy
Copy link

merge this

@JustLoveBeingAnOwl
Copy link
Contributor Author

merge this

Am I allowed to bump my PRs?

@CVSthePharmacy
Copy link

merge this

Am I allowed to bump my PRs?

i don't think so but I'm fully supportive of it

@xTrainx xTrainx added Awaiting Input Code has been checked, waiting for other's input on the subject Balance this PR is aimed at balancing one or more aspect of the game Approved for Testmerge A reviewer has approved this to be testmerged. labels Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved for Testmerge A reviewer has approved this to be testmerged. Awaiting Input Code has been checked, waiting for other's input on the subject Balance this PR is aimed at balancing one or more aspect of the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants