Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a patch for Changesets to allow legacy tags #2964

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

carbonrobot
Copy link
Contributor

@carbonrobot carbonrobot commented Nov 13, 2024

Creates a patch for changesets so that it respects the publishConfig.tags property in the package.json files for Victory-Native.

Currently, our CI process publishes a victory-native package from this repo AND from the Victory Native XL Repo. Both packages use the same name, but should use different tags on NPM in order to avoid crashing into each other.

image

Also removes changesets from non-package workspaces.

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: e429aa8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview Nov 13, 2024 3:28pm

@carbonrobot carbonrobot changed the title ci/changesets patch Create a patch for Changesets to allow legacy tags Nov 13, 2024
demo/rn/package.json Show resolved Hide resolved
website/package.json Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@keithluchtel keithluchtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@carbonrobot carbonrobot merged commit 7eafe76 into main Nov 13, 2024
4 checks passed
@carbonrobot carbonrobot deleted the ci/changesets-patch branch November 13, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants