Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow empty tick values #2671

Merged
merged 5 commits into from
Nov 15, 2023
Merged

fix: allow empty tick values #2671

merged 5 commits into from
Nov 15, 2023

Conversation

msabree
Copy link
Contributor

@msabree msabree commented Nov 7, 2023 •
edited
Loading

Issue Link: #1300

Allow empty tickValues and display an empty graph. The suggested work around was tickValues={[null]}. We can now do: tickValues={[]}.

Before with empty tick values:

Screenshot 2023-11-07 at 2 00 03 PM

After:

Screenshot 2023-11-08 at 9 56 24 AM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ed4b2fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 2:36pm

scottrippey
scottrippey approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@scottrippey scottrippey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion, otherwise lgtm

packages/victory-axis/src/helper-methods.tsx Show resolved Hide resolved
@msabree msabree merged commit 6dc9f10 into main Nov 15, 2023
6 of 7 checks passed
@msabree msabree deleted the bug/1300/empty-tick-values branch November 15, 2023 15:11
This was referenced May 25, 2024
Open
Open
@TheSimplestUserName TheSimplestUserName mentioned this pull request Jul 23, 2024
Open
@TheSimplestUserName TheSimplestUserName mentioned this pull request Sep 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottrippey scottrippey scottrippey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msabree @scottrippey