You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This all looks good to me. CI is choking on the 20.x with this though:
/home/runner/work/victory/victory/node_modules/.pnpm/[email protected]/node_modules/proper-lockfile/lib/lockfile.js:213
onCompromised: (err) => { throw err; },
^
[Error: ENOENT: no such file or directory, stat '/home/runner/work/victory/victory/packages/victory-voronoi-container/.wireit/6275696c643a6c69623a636a73/lock.lock'] {
errno: -2,
code: 'ECOMPROMISED',
syscall: 'stat',
path: '/home/runner/work/victory/victory/packages/victory-voronoi-container/.wireit/6275696c643a6c69623a636a73/lock.lock'
}
Looks like something weird going on with wireit cache. I'm going to pull this down locally and run with node 20.8.0 to see if it's something in the GH actions cache that we need to blast away.
Completed just fine locally, so looks like we've got a little bit of cache investigation to undertake (and I don't think GH offers a way to e.g. "nuke all 1367 cache artifacts"), ought to be a fun little adventure.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
carbonrobot
requested review from
ryan-roemer,
carloskelly13,
gksander and
mattjw79
Upgrades the CI to default to Node 18.x and refactors the common CI setup into a reusable action.