Fix calculating y scale range based on label position configurations (#…

…445)
FormidableLabs · Dec 9, 2024 · bd0bc33 · bd0bc33
1 parent 9ab0e9a
commit bd0bc33
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/red-taxis-beam.md b/.changeset/red-taxis-beam.md
@@ -0,0 +1,5 @@
+---
+"victory-native": patch
+---
+
+Fix calculating y scale range based on label position configurations.
diff --git a/lib/src/cartesian/utils/transformInputData.ts b/lib/src/cartesian/utils/transformInputData.ts
@@ -129,20 +129,20 @@ export const transformInputData = <
         (typeof yAxis?.tickCount === "number"
           ? yAxis?.tickCount
           : xAxis?.tickCount) ?? 0;
-      const yLabelPosition = yAxis?.labelPosition;
-      const xAxisSide = xAxis?.axisSide;
       const yLabelOffset = yAxis.labelOffset ?? 0;
+      const xAxisSide = xAxis?.axisSide;
+      const xLabelPosition = xAxis?.labelPosition;
 
       // bottom, outset
-      if (xAxisSide === "bottom" && yLabelPosition === "outset") {
+      if (xAxisSide === "bottom" && xLabelPosition === "outset") {
         return [
           outputWindow.yMin,
           outputWindow.yMax +
             (xTickCount > 0 ? -fontHeight - yLabelOffset * 2 : 0),
         ];
       }
       // Top outset
-      if (xAxisSide === "top" && yLabelPosition === "outset") {
+      if (xAxisSide === "top" && xLabelPosition === "outset") {
         return [
           outputWindow.yMin +
             (xTickCount > 0 ? fontHeight + yLabelOffset * 2 : 0),