Fix Styled Render Warning - SVG updates #68
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains new SVGs. The previous SVGs were minimized and that process replaced
viewbox
withwidth
andheight
attributes. Viewbox has been added back so that SVGs render appropriately.The PR also resolves the following console warning for the component:
Moved styled outside of the render function. Passing the Logo component as a
tagName
prop, so the badge can be rendered without passingisHoverable
to the DOM. This approach can be revisited once styled-components is upgraded to at least v5.1.0. Original dev work was done by Paula L. PR35 can be deleted after this is merged.