Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Styled Render Warning - SVG updates #68

Merged
merged 6 commits into from
Jun 24, 2022

Conversation

ryansrofe
Copy link
Contributor

@ryansrofe ryansrofe commented Jun 24, 2022

This PR contains new SVGs. The previous SVGs were minimized and that process replaced viewbox with width and height attributes. Viewbox has been added back so that SVGs render appropriately.

The PR also resolves the following console warning for the component:

The component Styled(Component) with the id of "sc-fzqAui" has been created dynamically. You may see this warning because you've called styled inside another component. To resolve this only create new StyledComponents outside of any render method and function component.

Moved styled outside of the render function. Passing the Logo component as a tagName prop, so the badge can be rendered without passing isHoverable to the DOM. This approach can be revisited once styled-components is upgraded to at least v5.1.0. Original dev work was done by Paula L. PR35 can be deleted after this is merged.

@ryansrofe ryansrofe added the bug Something isn't working label Jun 24, 2022
@ryansrofe ryansrofe requested a review from gksander June 24, 2022 16:35
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryansrofe ryansrofe merged commit 054d72b into master Jun 24, 2022
@ryansrofe ryansrofe deleted the bugfix/styled-render-warning branch June 24, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants