Do not overwrite the database default value if provided by attributes #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuben453
commented
Aug 2, 2021
| def test_overwrites_string_blank_value_in_mass_assignment | ||
| Book.default_value_for(:type, :allows_nil => false) { 'string' } | ||
| assert_equal 'string', Book.new(type: '').type | ||
| end |
There was a problem hiding this comment.
I noticed that this case did not have a test, so added one here.
reuben453
force-pushed
the
master
branch
2 times, most recently
from
78b2524
to
f77e56d
Compare
When a new database record has a column that is set to its database
default value, the "#{attribute}_changed?" method returns false,
which causes default_value_for to overwrite the database default.
This commit changes this behavior to not overwrite when the column
is being set by the initialization attributes.
|
@chrisarcand Would you mind having a look at these changes please? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new database record has a column that is set to its database default value, the
"#{attribute}_changed?"method returns false, which causes theconnection_default_value_definedvalue to be true and causesdefault_value_forto overwrite the database default.This PR changes this behavior to not overwrite when the column is being set by the initialization attributes. It will continue to overwrite the database default if the attribute is not present in the initialization attributes.
Example code: