Fix the logical flux control on WebUrlService Class - FLutterWeb #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bugs happens on FlutterWeb and when the initalRoute is "/"
The bug happens on FlutterWeb when you click on a link that contains a path after '#' or paste it on browser and the link ends with "/" and your initialRoute is "/" then the window reloads and redirects you to the home screen.
The reason for this bug is because on the WebUrlService, the logical check for UrlStrategy, first checks if the href ends with initialRoute, and because the link ends with "/" and the initalRoute is "/" the condition is satisfied and the user is redirected to the home screen and not to the desired destination.
To fix that, this PR only inverts the logic of the UrlStrategy check. The logic on this PR first checks if the href contains '#' than if it ends with initialRoute.
Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change
Related Issues
This PR can solve the bug related on issue #834
And i think it can solve the issue #956