Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Layout] - Implemented VStack and HStack (Resolves #22) #23

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

matthew-carroll
Copy link
Contributor

@matthew-carroll matthew-carroll commented Jun 2, 2024

[Layout] - Implemented VStack and HStack (Resolves #22)

I added an export for Material Colors and Color so that we can access them from swift_ui without importing material in client code.

I added golden_toolkit for golden tests. The pixel flakiness will be a problem, but goldens seem like the right tool for the job for testing layout behaviors.

@matthew-carroll
Copy link
Contributor Author

FYI @angelosilvestre @suragch - I'm gonna come back to this project now and then when I can. The UX Lead effort didn't work out because there simply wasn't enough follow through across the board. Therefore, I'm gonna try to contribute obvious widgets where I can. I welcome either of you to do the same, if you'd like. Perhaps once a critical foundation is built it will attract more capable and committed contributors.

If either of you do choose to contribute widgets, please be sure to file a ticket for that widget and assign it to yourself so that I don't accidentally work on the same thing.

@matthew-carroll matthew-carroll merged commit 70ac28f into main Jun 2, 2024
3 checks passed
@suragch
Copy link
Collaborator

suragch commented Jun 3, 2024

@matthew-carroll
Sounds good. I see you're assigned to Text (#2). I'll look for something easy to get my feet wet and then move on to others. Maybe the Rectangle you mentioned in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Primitives] - HStack and VStack
2 participants