Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch winget release action to manual #2231

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

JohnTheGr8
Copy link
Member

As discussed in #2218 I have updated the winget release action to only fire manually, as a temporary solution to #2086

@JohnTheGr8 JohnTheGr8 added CI/CD github_actions Pull requests that update GitHub Actions code labels Jul 9, 2023
@JohnTheGr8 JohnTheGr8 added this to the 1.16.0 milestone Jul 9, 2023
@JohnTheGr8 JohnTheGr8 requested a review from jjw24 July 9, 2023 17:05
@JohnTheGr8 JohnTheGr8 self-assigned this Jul 9, 2023
@jjw24 jjw24 added the bug Something isn't working label Jul 10, 2023
@jjw24
Copy link
Member

jjw24 commented Jul 10, 2023

Have you by any chance had a look at the GitHub action whether it will do anything if there is no new releases? Wondering if we can set it up as a cron job instead.

@JohnTheGr8
Copy link
Member Author

Have you by any chance had a look at the GitHub action whether it will do anything if there is no new releases? Wondering if we can set it up as a cron job instead.

Had a quick look, didn't see a way to configure this...

@jjw24
Copy link
Member

jjw24 commented Jul 10, 2023

I think this is doable based on vedantmgoyal9/winget-releaser#1, I will push up the change.

@JohnTheGr8
Copy link
Member Author

why would we want this to be a cron, though?

@jjw24
Copy link
Member

jjw24 commented Jul 10, 2023

Just so I don't have to wait around for the release to finish and remember to manually run the action, it's still the workaround for until PR 2185 is finished.

@JohnTheGr8
Copy link
Member Author

hopefully we'll finish that PR by the next release, so you'll only need to wait this once 😛

@jjw24
Copy link
Member

jjw24 commented Jul 10, 2023

Alright I have your word then, no pressure 😛 haha

@jjw24 jjw24 enabled auto-merge July 10, 2023 11:04
@jjw24 jjw24 merged commit e627667 into Flow-Launcher:dev Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants