Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Release Channel" Function #2017

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

"Release Channel" Function #2017

wants to merge 4 commits into from

Conversation

onesounds
Copy link
Contributor

@onesounds onesounds commented Mar 30, 2023 •
edited
Loading

image

What's the PR

  • A feature that allows you to change the version update channel to Stable or pre-release.

Test Cases

  • Each channel's version should be able to be updated and changed to another version while in use.
  • The version you are using should be displayed correctly in the version display.

Todos

  • Actually update to the latest url
  • Able to update to latest prerelease
  • Able to detect version diff with latest prerelease

Done

  • Release Url is changed
  • Can detect latest release/prerelease release info

@jjw24 jjw24 marked this pull request as draft March 30, 2023 20:34
@taooceros taooceros marked this pull request as ready for review March 30, 2023 22:23
@onesounds onesounds changed the title "Update Source" Function "Release Channel" Function Mar 31, 2023
@onesounds onesounds added the enhancement New feature or request label Mar 31, 2023
@jjw24
Copy link
Member

jjw24 commented Apr 2, 2023

Are the todos done?

@VictoriousRaptor
Copy link
Contributor

IIRC we can't detect correct prerelease version with Squirrel? (semver v2 not supported by squirrel)

@jjw24
Copy link
Member

jjw24 commented Apr 23, 2023

Yeah ok, issues of Squirrel identified in #1547

@jjw24 jjw24 marked this pull request as draft April 23, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@onesounds onesounds

@taooceros taooceros

Labels
enhancement New feature or request no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onesounds @jjw24 @VictoriousRaptor @taooceros