Search delay #1677

taooceros · 2022-12-18T06:01:24Z

For What?

For plug-ins with loading until results appear, such as translation or youtube (receving data from web). Each typing tries to load the results, causing a delay in typing.
e.g : tr h(stuck)e(stuck)l(stuck)l(stuck)o(stuck)...
To address this issue, this pr provides a setting to load the results after a certain period of time after typing stops rather than every typing.

What's the PR

Default Delay setting is possible in Flow. The default is 50 ms.
50ms / 100ms / 150ms.
The plug-in creator can set the delay. In this case, the delay value by the plug-in takes precedence.
Resolve Add input box input anti-shake function #1322
If there is no delay specified by the plug-in, use the default value for flow.
Each delay operates on a per-plug-in basis.

Test Cases

When entering a query, the result window must be displayed at the appropriate speed for each delay.
If delay is defined in the plug-in, the plug-in delay is applied.

References

…Launcher into search_delay

taooceros · 2022-12-20T20:28:31Z

Flow.Launcher/ViewModel/MainViewModel.cs

            try
            {
-                // Check the code, WhenAll will translate all type of IEnumerable or Collection to Array, so make an array at first
-                await Task.WhenAll(tasks);
+                await Parallel.ForEachAsync(plugins, currentCancellationToken,


This is for a better concurrency so we don't really need to do a context switch

jjw24 · 2022-12-27T04:25:04Z

If delay is defined in the plug-in, the plug-in delay is applied.

Is this tested?

taooceros · 2022-12-31T02:45:50Z

If delay is defined in the plug-in, the plug-in delay is applied.

Is this tested?

I test it

# Conflicts: # Flow.Launcher/Languages/en.xaml # Flow.Launcher/Languages/ko.xaml

Flow.Launcher/ViewModel/MainViewModel.cs

jjw24 · 2023-01-16T21:32:30Z

I am running into issue with this sort of result on the default delay:

Is it possible to have no delay?

jjw24 · 2023-01-16T21:39:48Z

Another one I am finding is using the default delay if you type dddddddddddddddddddddddddddd then delete it one by one, the trailing query suggestion text makes it feel really slow, like there is a bit of lag almost. On a prd release the trailing query suggestion text is removed a lot faster.

jjw24 · 2023-01-16T21:41:44Z

Correct me if I am wrong PRD has no query delay at all right?

…rch_delay

…r plugin is disabled before return it as valid plugin

taooceros · 2023-01-17T05:00:21Z

I am running into issue with this sort of result on the default delay:

Is it possible to have no delay?

I don't think this makes sense, because the current query model also have 45ms delay for global query. How fast do you type?

taooceros · 2023-01-17T05:01:31Z

Another one I am finding is using the default delay if you type dddddddddddddddddddddddddddd then delete it one by one, the trailing query suggestion text makes it feel really slow, like there is a bit of lag almost. On a prd release the trailing query suggestion text is removed a lot faster.

could you try run without debugger? the debugger makes thing much slower

VictoriousRaptor · 2023-01-17T08:07:12Z

Flow.Launcher/ViewModel/MainViewModel.cs

+                        await Task.Delay(pair.Metadata.SearchDelay
+                                         ?? (string.IsNullOrEmpty(query.ActionKeyword)
+                                             ? Settings.GlobalSearchDelay
+                                             : 0));


Is it possible for non global plugins to notify that should use user specified delay value?

And why use delay only for global searches?

VictoriousRaptor · 2023-01-17T09:04:36Z

Should we delay when typing the FIRST character?

github-actions · 2023-01-17T09:49:57Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (22)

ASponsor
combobox
embeded
happlebao
installbtn
IPublic
mainwindow
metadatas
Mvvm
otalcmd
overriden
Preinstalled
receving
Reloadable
scm
settingwindow
Txb
uninstallbtn
updatebtn
viewupdate
Wpf
ZIndex

To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Flow-Launcher/Flow.Launcher.git repository
on the search_delay branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/3938000201/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

jjw24 · 2023-01-17T19:45:37Z

I am running into issue with this sort of result on the default delay:

Is it possible to have no delay?

I don't think this makes sense, because the current query model also have 45ms delay for global query. How fast do you type?

I dont type that fast, but this is done with my normal speed.

jjw24 · 2023-01-17T19:46:27Z

Another one I am finding is using the default delay if you type dddddddddddddddddddddddddddd then delete it one by one, the trailing query suggestion text makes it feel really slow, like there is a bit of lag almost. On a prd release the trailing query suggestion text is removed a lot faster.

could you try run without debugger? the debugger makes thing much slower

This was tested not with debugger but an actual build, are you able to see what I am describing?

taooceros · 2023-02-04T17:58:53Z

you mean this?

taooceros · 2023-02-04T17:59:26Z

What about removing the autosuggestion whenever query change?

taooceros · 2024-06-19T19:01:34Z

Should we delay when typing the FIRST character?

huh maybe not

taooceros added 2 commits December 17, 2022 23:39

Global Delay Option

c3d0e31

Plugin Specific Delay

34e2ff6

onesounds marked this pull request as draft December 18, 2022 06:57

onesounds self-assigned this Dec 18, 2022

onesounds added the enhancement New feature or request label Dec 18, 2022

onesounds added 6 commits December 19, 2022 00:21

Add search delay item in settingwindow

8629d60

Adjust Key

84a55f0

Merge branch 'dev' into search_delay

1e86373

Adjust desc

eafd1ca

Adjust Item Texts

e82ca31

Merge branch 'search_delay' of https://github.com/Flow-Launcher/Flow.…

323424a

…Launcher into search_delay

onesounds marked this pull request as ready for review December 19, 2022 02:50

taooceros commented Dec 20, 2022

View reviewed changes

jjw24 modified the milestones: 1.11.0, Future Dec 27, 2022

Merge remote-tracking branch 'origin/dev' into search_delay

cc1f760

# Conflicts: # Flow.Launcher/Languages/en.xaml # Flow.Launcher/Languages/ko.xaml

jjw24 added the review in progress Indicates that a review is in progress for this PR label Jan 1, 2023

VictoriousRaptor reviewed Jan 4, 2023

View reviewed changes

Flow.Launcher/ViewModel/MainViewModel.cs Show resolved Hide resolved

taooceros added 2 commits January 16, 2023 22:12

Merge branch 'dev' of github.com:Flow-Launcher/Flow.Launcher into sea…

94c839f

…rch_delay

Make Global Search Delay only works for global query and check whethe…

60f766c

…r plugin is disabled before return it as valid plugin

This comment has been minimized.

Sign in to view

VictoriousRaptor reviewed Jan 17, 2023

View reviewed changes

Simplify get valid plugin logic

3ebf087

This comment has been minimized.

Sign in to view

VictoriousRaptor added 2 commits January 17, 2023 17:29

Update wording

fcd0e4a

Refactor search delay combobox

cc7ddee

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Mar 2, 2023

jjw24 added the review in progress Indicates that a review is in progress for this PR label Jun 23, 2023

jjw24 removed the review in progress Indicates that a review is in progress for this PR label Aug 8, 2023

jjw24 marked this pull request as draft June 22, 2024 02:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Search delay #1677

Search delay #1677

taooceros commented Dec 18, 2022 •

edited

Loading

taooceros Dec 20, 2022

jjw24 commented Dec 27, 2022

taooceros commented Dec 31, 2022

jjw24 commented Jan 16, 2023 •

edited

Loading

jjw24 commented Jan 16, 2023 •

edited

Loading

jjw24 commented Jan 16, 2023

taooceros commented Jan 17, 2023 •

edited

Loading

This comment has been minimized.

taooceros commented Jan 17, 2023

VictoriousRaptor Jan 17, 2023 •

edited

Loading

VictoriousRaptor Jan 17, 2023

This comment has been minimized.

VictoriousRaptor commented Jan 17, 2023

github-actions bot commented Jan 17, 2023 •

edited

Loading

jjw24 commented Jan 17, 2023

jjw24 commented Jan 17, 2023

taooceros commented Feb 4, 2023

taooceros commented Feb 4, 2023

taooceros commented Jun 19, 2024

Search delay #1677

Are you sure you want to change the base?

Search delay #1677

Conversation

taooceros commented Dec 18, 2022 • edited Loading

For What?

What's the PR

Test Cases

References

taooceros Dec 20, 2022

Choose a reason for hiding this comment

jjw24 commented Dec 27, 2022

taooceros commented Dec 31, 2022

jjw24 commented Jan 16, 2023 • edited Loading

jjw24 commented Jan 16, 2023 • edited Loading

jjw24 commented Jan 16, 2023

taooceros commented Jan 17, 2023 • edited Loading

This comment has been minimized.

taooceros commented Jan 17, 2023

VictoriousRaptor Jan 17, 2023 • edited Loading

Choose a reason for hiding this comment

VictoriousRaptor Jan 17, 2023

Choose a reason for hiding this comment

This comment has been minimized.

VictoriousRaptor commented Jan 17, 2023

github-actions bot commented Jan 17, 2023 • edited Loading

@check-spelling-bot Report

🔴 Please review

jjw24 commented Jan 17, 2023

jjw24 commented Jan 17, 2023

taooceros commented Feb 4, 2023

taooceros commented Feb 4, 2023

taooceros commented Jun 19, 2024

taooceros commented Dec 18, 2022 •

edited

Loading

jjw24 commented Jan 16, 2023 •

edited

Loading

jjw24 commented Jan 16, 2023 •

edited

Loading

taooceros commented Jan 17, 2023 •

edited

Loading

VictoriousRaptor Jan 17, 2023 •

edited

Loading

github-actions bot commented Jan 17, 2023 •

edited

Loading