Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAII #36

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

RAII #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d284fc6
calling exit(int) does not play well with RAII
ferkulat Dec 21, 2017
33fffb6
fixed TEST_CASE( "Parse help", "[help]" )
ferkulat Dec 21, 2017
42320bf
delete resource before erasing
ferkulat Dec 21, 2017
a0a3a99
Replace raw pointer with std::unique_ptr
ferkulat Dec 21, 2017
09ea54b
added target sample for make
ferkulat Dec 21, 2017
f8b185b
Solution for the exit() problem: Policy class
haschke-felix Oct 12, 2024
3a23b24
cleanup RAII usign make_unique
haschke-felix Oct 12, 2024
72ca4e2
Merge branch 'master' into RAII
haschke-felix Oct 12, 2024
18f868a
use shared pointer
haschke-felix Oct 12, 2024
e2b7ebc
fix test for exit problem
haschke-felix Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmdparser.Test/tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,15 @@ TEST_CASE( "Parse help", "[help]" ) {
"--help"
};

Parser parser(2, args);
ParserWithPolicy<NoExit> parser(2, args);
const auto value = parser.run(output, errors);
const std::string prefix = "Available parameters:";

REQUIRE(parser.has_help() == true);
REQUIRE(parser.app_name() == "myapp");
REQUIRE(value == false);
REQUIRE(output.str().substr(0, prefix.size()) == prefix);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry cannot accept PRs that break / change existing tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that testcase never been reached beforehand anyway as exit() is called?

// true as it met all required arguments.
REQUIRE(value == true);
REQUIRE(output.str().find(prefix) != std::string::npos);
}

TEST_CASE( "No help", "[help]" ) {
Expand Down
Loading