Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Algae #28

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Algae #28

merged 6 commits into from
Jan 21, 2025

Conversation

ShalevAtA
Copy link

No description provided.

@tomtzook tomtzook self-requested a review January 16, 2025 22:28
tomtzook
tomtzook requested changes Jan 16, 2025
View reviewed changes
Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of small problems.

Also initialize subsystems in Robot class

src/main/java/frc/robot/subsystems/AlgaeGripper.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AlgaeGripper.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AlgaeGripper.java Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AlgaeGripper.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AlgaeArm.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/HoldAlgae.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/ExtendedAlgaeArm.java Show resolved Hide resolved
src/main/java/frc/robot/commands/ExtendedAlgaeArm.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CollectAlgae.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/CollectAlgae.java Outdated Show resolved Hide resolved
tomtzook
tomtzook requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you ignored some of my comments, make sure you go over all of them. Some may be collapsed under "hidden items" link

src/main/java/frc/robot/commands/HoldAlgae.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/ExtendedAlgaeArm.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/ReleaseAlgae.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotMap.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotMap.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/ReleaseAlgae.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/RetractAlgaeArm.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/subsystems/AlgaeArm.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotMap.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotMap.java Outdated Show resolved Hide resolved
@tomtzook tomtzook added this to the Implementation milestone Jan 19, 2025
tomtzook
tomtzook requested changes Jan 19, 2025
View reviewed changes
Copy link
Member

@tomtzook tomtzook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small thing left

src/main/java/frc/robot/subsystems/AlgaeArm.java Outdated Show resolved Hide resolved
@tomtzook tomtzook merged commit 47533a4 into master Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtzook tomtzook tomtzook approved these changes

Assignees

@stavit456 stavit456

Labels
subsystems
Projects
None yet
Milestone
Implementation
Development

Successfully merging this pull request may close these issues.
3 participants
@ShalevAtA @tomtzook @stavit456