-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added urllib3 < 2.X compatibility for the Retry object #13
Conversation
If this really is the fix, it sounds like an issue with |
bb9a5a2
to
8170de1
Compare
@isra17 to me it feels more like Splunk Enterprise not updating their underlying Python version fast enough; 3.9 is old and that OpenSSL version has been outdated for a long time. Requests is doing the right thing as far as I'm concerned |
8170de1
to
9fdb856
Compare
Isn't python 3.9 already tested in the CI tho? Can we update the CI matrix to test for your issue? |
9fdb856
to
cef30e2
Compare
98b2d50
to
3b2469e
Compare
1e5afe0
to
3645200
Compare
Added matrix to test if it also works with urllib3 <2.x
3645200
to
a17de78
Compare
requests > 2.30 uses the urllib3 version 2.X which removed the compatibility for OpenSSL < 1.1.1, but Python 3.9 uses OpenSSL 1.0.2z.
Adding specific versions that will make the SDK compatible with Python 3.9