Added urllib3 < 2.X compatibility for the Retry object #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this really is the fix, it sounds like an issue with |
TyMarc
force-pushed
the
mahinse/support_python3_9
branch
from
bb9a5a2
to
8170de1
Compare
|
@isra17 to me it feels more like Splunk Enterprise not updating their underlying Python version fast enough; 3.9 is old and that OpenSSL version has been outdated for a long time. Requests is doing the right thing as far as I'm concerned |
TyMarc
force-pushed
the
mahinse/support_python3_9
branch
from
8170de1
to
9fdb856
Compare
aviau
reviewed
Oct 21, 2024
isra17
reviewed
Oct 21, 2024
aviau
reviewed
Oct 21, 2024
aviau
reviewed
Oct 21, 2024
Isn't python 3.9 already tested in the CI tho? Can we update the CI matrix to test for your issue? |
TyMarc
force-pushed
the
mahinse/support_python3_9
branch
from
9fdb856
to
cef30e2
Compare
aviau
reviewed
Oct 21, 2024
TyMarc
force-pushed
the
mahinse/support_python3_9
branch
4 times, most recently
from
98b2d50
to
3b2469e
Compare
aviau
reviewed
Oct 21, 2024
TyMarc
force-pushed
the
mahinse/support_python3_9
branch
14 times, most recently
from
1e5afe0
to
3645200
Compare
Added matrix to test if it also works with urllib3 <2.x
TyMarc
force-pushed
the
mahinse/support_python3_9
branch
from
3645200
to
a17de78
Compare
TyMarc
changed the title
aviau
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requests > 2.30 uses the urllib3 version 2.X which removed the compatibility for OpenSSL < 1.1.1, but Python 3.9 uses OpenSSL 1.0.2z.
Adding specific versions that will make the SDK compatible with Python 3.9