Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Gunicorn logger not sending StatsD stats #4819

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Nov 7, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This enables StatsD support for our own GunicornJsonCapableLogger.

How did you test this code?

Will test manually with @rolodato's StatsD debug setup.

@khvn26 khvn26 requested a review from a team as a code owner November 7, 2024 09:20
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team November 7, 2024 09:20
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:56am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:56am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2024 0:56am

@github-actions github-actions bot added the api Issue related to the REST API label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4819 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4819 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4819 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4819 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4819 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4819 Finished ✅ Results

@github-actions github-actions bot added the fix label Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Uffizzi Ephemeral Environment deployment-58057

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4819

📄 View Application Logs etc.

What is Uffizzi? Learn more!

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 97.32%. Comparing base (e6f1bac) to head (8157bba).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
api/util/logging.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
- Coverage   97.33%   97.32%   -0.01%     
==========================================
  Files        1180     1180              
  Lines       41223    41225       +2     
==========================================
+ Hits        40123    40124       +1     
- Misses       1100     1101       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant