fix: Avoid a long table lock for the first_name
migration
#4816
+129
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
This replaces
users.0039
migration with a manual one that aims to avoid long locking theusers_ffadminusers
table during migration execution.A new
users_ffadminusers.first_name_v2
column is added and is backing theFFAdminUser.first_name
field.Notes:
migrations
table mofification is in order.ALTER TABLE {table_name} RENAME COLUMN first_name_v2 TO first_name
statement to the forward migration.How did you test this code?
Added two unit tests for reverse and forward migrations.