Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove realtime_setting FoF flag #4798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: Remove realtime_setting FoF flag #4798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e4b35
Remove realtime_setting FoF flag
rolodato Nov 4, 2024
476a44f
Tweak wording
rolodato Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/web/components/PlanBasedAccess.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ export const featureDescriptions: Record<PaidFeature, any> = {
title: 'Role-based access control',
},
'REALTIME': {
description: 'Add real time detection of feature flag changes in your SDK.',
description: 'Add real-time detection of feature flag changes in your SDK.',
docs: 'https://docs.flagsmith.com/advanced-use/real-time-flags',
title: 'Realtime Updates',
title: 'Real-time flag updates',
},
'SAML': {
description: 'Configure 2FA, SAML, Okta, ADFS and LDAP.',
Expand Down
24 changes: 10 additions & 14 deletions frontend/web/components/pages/ProjectSettingsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,20 +541,16 @@ const ProjectSettingsPage = class extends Component {
data-test='js-sdk-settings'
tabLabel='SDK Settings'
>
{Utils.isSaas() &&
Utils.getFlagsmithHasFeature('realtime_setting') &&
Utils.isSaas() && (
<FormGroup className='mt-4 col-md-8'>
<Setting
feature='REALTIME'
disabled={isSaving}
onChange={() =>
this.toggleRealtimeUpdates(project, editProject)
}
checked={project.enable_realtime_updates}
/>
</FormGroup>
)}
<FormGroup className='mt-4 col-md-8'>
<Setting
feature='REALTIME'
disabled={isSaving}
onChange={() =>
this.toggleRealtimeUpdates(project, editProject)
}
checked={project.enable_realtime_updates}
/>
</FormGroup>
<div className='mt-4'>
<form onSubmit={saveProject}>
<FormGroup className='mt-4 col-md-8'>
Expand Down
Loading