Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Segment matching for sub rules and conditions #4776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Segment matching for sub rules and conditions #4776

wants to merge 1 commit into from

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Oct 28, 2024 •
edited
Loading

Changes

This adds a test for the related PR in the Flagsmith commons repo. This PR will not be merged until the related PR has been merged into commons and a new tag is released for it.

How did you test this code?

Test both conditions and rules to match. For sub rules we rely on matching to a parent rule, which itself must match to the segment rule.

@zachaysan zachaysan requested a review from a team as a code owner October 28, 2024 12:53
@zachaysan zachaysan requested review from khvn26 and removed request for a team October 28, 2024 12:53
@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 28, 2024 0:53am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 28, 2024 0:53am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 28, 2024 0:53am

@github-actions github-actions bot added the api Issue related to the REST API label Oct 28, 2024
@zachaysan zachaysan mentioned this pull request Oct 28, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4776 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4776 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4776 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4776 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4776 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4776 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

Uffizzi Ephemeral Environment deployment-57676

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4776

📄 View Application Logs etc.

What is Uffizzi? Learn more!

khvn26
khvn26 reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are failing in CI — can't approve the PR yet.

@matthewelwell
Copy link
Contributor

Looks like the tests are failing in CI — can't approve the PR yet.

@khvn26 I think that's because this PR needs reviewing and merging first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khvn26 khvn26 khvn26 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api Issue related to the REST API testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachaysan @matthewelwell @khvn26