early return for updating same role

Finschia · May 24, 2024 · 1e9244d · 1e9244d
1 parent 38ee123
commit 1e9244d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/x/fbridge/keeper/auth.go b/x/fbridge/keeper/auth.go
@@ -61,6 +61,10 @@ func (k Keeper) addVote(ctx sdk.Context, proposalID uint64, voter sdk.AccAddress
 
 func (k Keeper) updateRole(ctx sdk.Context, role types.Role, addr sdk.AccAddress) error {
 	previousRole := k.GetRole(ctx, addr)
+	if previousRole == role {
+		return nil
+	}
+
 	roleMeta := k.GetRoleMetadata(ctx)
 	nInactive := k.GetBridgeInactiveCounter(ctx)
 

diff --git a/x/fbridge/keeper/auth_test.go b/x/fbridge/keeper/auth_test.go
@@ -52,6 +52,10 @@ func TestAssignRole(t *testing.T) {
 	err = k.updateRole(ctx, types.RoleOperator, addrs[1])
 	require.NoError(t, err)
 	require.Equal(t, types.RoleMetadata{Guardian: 1, Operator: 1, Judge: 0}, k.GetRoleMetadata(ctx))
+
+	// 4. Guardian assigns an address to a same role
+	err = k.updateRole(ctx, types.RoleOperator, addrs[1])
+	require.NoError(t, err)
 }
 
 func TestBridgeHaltAndResume(t *testing.T) {