Move Storybook to the repository root #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-like-robots
requested review from
benbarnett,
apaleslimghost,
debugwand and
dan-searle
|
I've removed the |
- Adds Storybook v5 as a top-level dependency - Copies configuration from subdirectory to .storybook folder in repo root - References included components by path specifier instead of package name
This is now handled by the existing "root" cache and cache key.
…rectory within the Storybook folder
apaleslimghost
force-pushed
the
matth/storybook-top-level
branch
from
8a46c7d to
0b0465d
Compare
rowanbeentje
pushed a commit
that referenced
this pull request
Nov 24, 2021
Move Storybook to the repository root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves Storybook from a subdirectory (
tools/x-storybook) up to the repository root.This enables several useful features as discussed in #177:
Please note that this PR does not make it possible to directly include a component's source code into a story as this will require changes to JSX transpilation. I will do this in another PR.
Please also note that this implements Storybook v5 rather than the previous v4. Other than changes to configuration the "options" add-on has been deprecated.
To rebase onto this branch you will need to:
.storybook/register-components.js, please note that you should now use a path specifier rather than a bare module reference.x-storybook/package.json