Code

X topic search#218

Code

Merged

apaleslimghost merged 71 commits intomainFinancial-Times/x-dash:mainfrom x-topic-searchFinancial-Times/x-dash:x-topic-searchCopy head branch name to clipboardJan 31, 2022

+646-2

Commits

Commits on Jan 31, 2022

• first commit

  

  fenglish

  authored and

  apaleslimghost

  committed
  e5d3803

  Copy full SHA for e5d3803

• apply existing functions from ft.com topic search bar

  

  fenglish

  authored and

  apaleslimghost

  committed
  f1cba1c

  Copy full SHA for f1cba1c

• change currentlyFollowingTopics = => followedTopics

  

  fenglish

  authored and

  apaleslimghost

  committed
  3678a13

  Copy full SHA for 3678a13

• make JSX being its own JSX component

  

  fenglish

  authored and

  apaleslimghost

  committed
  85ba407

  Copy full SHA for 85ba407

• reflect reviews

  

  fenglish

  authored and

  apaleslimghost

  committed
  ddbdb06

  Copy full SHA for ddbdb06

• use x-follow-button

  

  fenglish

  authored and

  apaleslimghost

  committed
  69753c0

  Copy full SHA for 69753c0

• add snapshot tests

  

  fenglish

  authored and

  apaleslimghost

  committed
  c5702ac

  Copy full SHA for c5702ac

• set empty array as followedTopic's default

  

  fenglish

  authored and

  apaleslimghost

  committed
  05cb353

  Copy full SHA for 05cb353

• display correct sentence when matchingFollowedTopic is only one

  

  fenglish

  authored and

  apaleslimghost

  committed
  5f074d4

  Copy full SHA for 5f074d4

• use onInput instead of onChange

  

  fenglish

  authored and

  apaleslimghost

  committed
  2cc7644

  Copy full SHA for 2cc7644

• Do not lint x-docs build output

  

  fenglish

  authored and

  apaleslimghost

  committed
  47c745b

  Copy full SHA for 47c745b

• modify styling

  

  fenglish

  authored and

  apaleslimghost

  committed
  f941991

  Copy full SHA for f941991

• delete unnecessary classes

  

  fenglish

  authored and

  apaleslimghost

  committed
  2ed3703

  Copy full SHA for 2ed3703

• update x-follow-button to the latest version

  

  fenglish

  authored and

  apaleslimghost

  committed
  69ec345

  Copy full SHA for 69ec345

• update x-follow-button to v0.0.8

  

  fenglish

  authored and

  apaleslimghost

  committed
  b81fcd3

  Copy full SHA for b81fcd3

• update x-follow-button

  

  fenglish

  authored and

  apaleslimghost

  committed
  8f201df

  Copy full SHA for 8f201df

• update snapshots

  

  fenglish

  authored and

  apaleslimghost

  committed
  37c839f

  Copy full SHA for 37c839f

• pass csrfToken for x-follow-button

  

  fenglish

  authored and

  apaleslimghost

  committed
  3051a7a

  Copy full SHA for 3051a7a

• Add topicFollowed/topicUnfollowed externally triggered actions (#232)

  Show description for 33aa09a
  

  fenglish

  authored and

  apaleslimghost

  committed
  33aa09a

  Copy full SHA for 33aa09a

• Remove followedTopic ids from the api query

  Show description for bfc262e
  

  fenglish

  authored and

  apaleslimghost

  committed
  bfc262e

  Copy full SHA for bfc262e

• Separate api response into followed topics and not followed topics

  

  fenglish

  authored and

  apaleslimghost

  committed
  b3ac018

  Copy full SHA for b3ac018

• Change topic.name => topic.prefLabel to display topic's name

  Show description for d228268
  

  fenglish

  authored and

  apaleslimghost

  committed
  d228268

  Copy full SHA for d228268

• remove unused variable

  

  fenglish

  authored and

  apaleslimghost

  committed
  2916c3b

  Copy full SHA for 2916c3b

• Move the logic of deciding which message is displayed into TopicSearch.jsx

  

  fenglish

  authored and

  apaleslimghost

  committed
  3c9839f

  Copy full SHA for 3c9839f

• Treat no followed topics are passed

  

  fenglish

  authored and

  apaleslimghost

  committed
  b5f9b04

  Copy full SHA for b5f9b04

• Simplify the logic of separating suggestions into followedTopics and unfollowedTopics

  

  fenglish

  authored and

  apaleslimghost

  committed
  d6c62c2

  Copy full SHA for d6c62c2

• Move the process of applying suggestion url

  

  fenglish

  authored and

  apaleslimghost

  committed
  528fed3

  Copy full SHA for 528fed3

• Change from followedTopics to followedTopicIds to make interaction simpler

  

  fenglish

  authored and

  apaleslimghost

  committed
  26cc7b1

  Copy full SHA for 26cc7b1

• set more specific key for all-followed topic list

  

  fenglish

  authored and

  apaleslimghost

  committed
  0230e90

  Copy full SHA for 0230e90

• tidy up

  

  fenglish

  authored and

  apaleslimghost

  committed
  d97fbba

  Copy full SHA for d97fbba

• modify test from two all followed topics to three all followed topics

  

  fenglish

  authored and

  apaleslimghost

  committed
  2e88e97

  Copy full SHA for 2e88e97

• modify followedTopicIds explanation in Readme

  

  fenglish

  authored and

  apaleslimghost

  committed
  a6f59b4

  Copy full SHA for a6f59b4

• tidy up

  

  fenglish

  authored and

  apaleslimghost

  committed
  4e4d2ff

  Copy full SHA for 4e4d2ff

• Remove onBlur which hides result

  Show description for d0df75b
  

  fenglish

  authored and

  apaleslimghost

  committed
  d0df75b

  Copy full SHA for d0df75b

• Disable input box's autocomplete (#237)

  Show description for b35fed9
  

  fenglish

  authored and

  apaleslimghost

  committed
  b35fed9

  Copy full SHA for b35fed9

• Pass followedTopicIds into SuggestionList to update FollowButton

  Show description for 1f771ef
  

  fenglish

  authored and

  apaleslimghost

  committed
  1f771ef

  Copy full SHA for 1f771ef

• Apply suggestion mapping directly

  

  fenglish

  authored and

  apaleslimghost

  committed
  7619cbe

  Copy full SHA for 7619cbe

• Move the decision of displaying result to one place

  

  fenglish

  authored and

  apaleslimghost

  committed
  5bb4eed

  Copy full SHA for 5bb4eed

• Make the condition to display result more readable

  

  fenglish

  authored and

  apaleslimghost

  committed
  7ff55ad

  Copy full SHA for 7ff55ad

• update x-follow-button to 0.0.11

  

  fenglish

  authored and

  apaleslimghost

  committed
  43ae068

  Copy full SHA for 43ae068

• Remove unnecessary data-component="topic-search"

  

  fenglish

  authored and

  apaleslimghost

  committed
  1617c23

  Copy full SHA for 1617c23

• Apply custom styles to search cancel button (#242)

  Show description for 4f18169
  

  fenglish

  authored and

  apaleslimghost

  committed
  4f18169

  Copy full SHA for 4f18169

• Change testing style from snapshots tests to unit tests (#228)

  

  fenglish

  authored and

  apaleslimghost

  committed
  a3e8cab

  Copy full SHA for a3e8cab

• Extend Component class instead of using x-interaction

  

  dan-searle

  authored and

  apaleslimghost

  committed
  7e5df9f

  Copy full SHA for 7e5df9f

• followedTopicIds prop is expected to be updated when followed topics change.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  07e0467

  Copy full SHA for 07e0467

• Create story knob for followedTopicIds prop.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  ba56f39

  Copy full SHA for ba56f39

• Minor improvement to arrayToSentence function.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  9e1f5a6

  Copy full SHA for 9e1f5a6

• Ensure results are only displayed if they are for the current search term (defends against slow API response causing results to be shown when input is now empty).

  

  dan-searle

  authored and

  apaleslimghost

  committed
  31126f5

  Copy full SHA for 31126f5

• Simplify get-suggestions response processing.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  014d87b

  Copy full SHA for 014d87b

• Slightly more descriptive tests.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  447dea8

  Copy full SHA for 447dea8

• Remove redundant throw in catch.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  97be6f1

  Copy full SHA for 97be6f1

• Bug fix: csrfToken is a prop not state...

  

  dan-searle

  authored and

  apaleslimghost

  committed
  b5996bb

  Copy full SHA for b5996bb

• Extract arrayToSentence function to be a component.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  45181e5

  Copy full SHA for 45181e5

• Don't show any search results if the searchTerm length is less than the minSearchLength.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  85d16af

  Copy full SHA for 85d16af

• Remove "you already follow..." messaging and just display any suggestions with their follow buttons in the appropriate states.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  9adec50

  Copy full SHA for 9adec50

• Overwrite top/bottom padding 0 to keep input height the same across browsers

  Show description for 1c3edc0
  

  fenglish

  authored and

  apaleslimghost

  committed
  1c3edc0

  Copy full SHA for 1c3edc0

• Remove o-forms

  Show description for cc8ddb4
  

  fenglish

  authored and

  apaleslimghost

  committed
  cc8ddb4

  Copy full SHA for cc8ddb4

• Select the text when input box is changed from blur to focus

  

  fenglish

  authored and

  apaleslimghost

  committed
  396d0db

  Copy full SHA for 396d0db

• Delete outdated explanation

  

  fenglish

  authored and

  apaleslimghost

  committed
  55f0a05

  Copy full SHA for 55f0a05

• Delete spaces

  

  fenglish

  authored and

  apaleslimghost

  committed
  2a4a01d

  Copy full SHA for 2a4a01d

• Set more specific key instead of map index

  

  fenglish

  authored and

  apaleslimghost

  committed
  93d1606

  Copy full SHA for 93d1606

• Update README

  

  fenglish

  authored and

  apaleslimghost

  committed
  0ba9879

  Copy full SHA for 0ba9879

• Correct left alignment of no-suggestions bullet list.

  

  dan-searle

  authored and

  apaleslimghost

  committed
  9a1297a

  Copy full SHA for 9a1297a

• Unlock x-follow-button version to include compatible versions

  

  rowanbeentje

  authored and

  apaleslimghost

  committed
  4f40d01

  Copy full SHA for 4f40d01

• Bump x-follow-button dependency of x-topic-search to ^0.0.12

  

  rowanbeentje

  authored and

  apaleslimghost

  committed
  13dcebc

  Copy full SHA for 13dcebc

• AT-2015: Use a render prop for the follow button to make it work with x-follow-button 0.0.12

  

  Pavel Pichrt

  authored and

  apaleslimghost

  committed
  b0149e1

  Copy full SHA for b0149e1

• AT-2015: Added prop docs

  

  Pavel Pichrt

  authored and

  apaleslimghost

  committed
  a0f64a5

  Copy full SHA for a0f64a5

• Miggrate x-topic-search Storybook setup to v6 format

  

  rowanbeentje

  authored and

  apaleslimghost

  committed
  0d6ba09

  Copy full SHA for 0d6ba09

• Update x-topic-search bower dependencies to majoor versions used across the rest of x-dash

  

  rowanbeentje

  authored and

  apaleslimghost

  committed
  0fb6614

  Copy full SHA for 0fb6614

• Update x-topic-search to use the merged component version of x-follow-button instead of the prerelease branch

  

  rowanbeentje

  authored and

  apaleslimghost

  committed
  9b96d24

  Copy full SHA for 9b96d24

• Update x-topic-search test setup so that fetchMock is set up in the beforeEach() blocks, to allow afterEach() to tear it down after each use instead of the at-init setup in each describe() block

  

  rowanbeentje

  authored and

  apaleslimghost

  committed
  8c7f58c

  Copy full SHA for 8c7f58c