Don't show any search results if the searchTerm length is less than t…

…he minSearchLength.
Financial-Times · Feb 1, 2019 · b5f80c5 · b5f80c5
1 parent 69ed7ad
commit b5f80c5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/components/x-topic-search/src/TopicSearch.jsx b/components/x-topic-search/src/TopicSearch.jsx
@@ -46,23 +46,20 @@ class TopicSearch extends Component {
 
 		if (searchTerm.length >= this.minSearchLength) {
 			this.getSuggestions(searchTerm, this.maxSuggestions, this.apiUrl, this.props.followedTopicIds)
-				.then(({ resultsForTerm, followedSuggestions, unfollowedSuggestions }) => {
+				.then(({ followedSuggestions, unfollowedSuggestions }) => {
 					this.setState({
-						resultsForTerm,
 						followedSuggestions,
 						unfollowedSuggestions,
 						showResult: true
 					});
 				})
 				.catch(() => {
 					this.setState({
-						resultsForTerm: null,
 						showResult: false
 					});
 				});
 		} else {
 			this.setState({
-				resultsForTerm: null,
 				showResult: false
 			});
 		}
@@ -86,7 +83,7 @@ class TopicSearch extends Component {
 
 	render() {
 		const { csrfToken, followedTopicIds } = this.props;
-		const { followedSuggestions, resultsForTerm, searchTerm, showResult, unfollowedSuggestions } = this.state;
+		const { followedSuggestions, searchTerm, showResult, unfollowedSuggestions } = this.state;
 
 		return (
 			<div className={ classNames(styles['container']) } ref={el => this.rootEl = el}>
@@ -110,7 +107,7 @@ class TopicSearch extends Component {
 					/>
 				</div>
 
-				{ showResult && resultsForTerm === searchTerm &&
+				{ showResult && searchTerm.length >= this.minSearchLength &&
           <ResultContainer
 						followedSuggestions={ followedSuggestions }
 						unfollowedSuggestions={ unfollowedSuggestions }

diff --git a/components/x-topic-search/src/lib/get-suggestions.js b/components/x-topic-search/src/lib/get-suggestions.js
@@ -17,7 +17,6 @@ export default (searchTerm, maxSuggestions, apiUrl, followedTopicIds) => {
 			return response.json();
 		})
 		.then(suggestions => ({
-			resultsForTerm: searchTerm,
 			followedSuggestions: suggestions.filter(suggestion => followedTopicIds.includes(suggestion.id)),
 			unfollowedSuggestions: suggestions.filter(suggestion => !followedTopicIds.includes(suggestion.id))
 		}));