Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Correct o-header font size #1951

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: Correct o-header font size #1951

merged 1 commit into from
Jan 30, 2025

Conversation

notlee
Copy link
Contributor

@notlee notlee commented Jan 28, 2025 •
edited
Loading

  • Where a px value was used directly, font size had visually increased due to Metric2
  • Restores button radius for standalone buttons

production / 2025-release currently (the problem)
Screenshot 2025-01-28 at 15 52 17

now

  • Slightly larger copy inline with standard use-cases (16px, but with metric2).
  • Note form placeholder text is massive. This is by design but this specific scenario could use a review. Out of scope for this PR.
    Screenshot 2025-01-28 at 16 26 13

@notlee notlee requested a review from a team as a code owner January 28, 2025 16:13
@notlee
chore: Correct o-header font size
941ba0d 
Where a px value was used directly, font size had visually increased due to Metric2
@notlee notlee force-pushed the 2025-release-replace-px-values branch from c16bc26 to 941ba0d Compare January 28, 2025 16:17
j-mes
j-mes approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@j-mes j-mes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I'm wondering re: failing test. I'll check that out for you.

@notlee
Copy link
Contributor Author

notlee commented Jan 30, 2025

@j-mes yeah I assumed that was an existing error that your PR fixes 🤞 I'll wait to merge this to see

@notlee notlee merged commit 9bcf2ef into 2025-release Jan 30, 2025
4 of 6 checks passed
@notlee notlee deleted the 2025-release-replace-px-values branch January 30, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mes j-mes j-mes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notlee @j-mes