Fix typo in preinstall script dependency #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
check-engine
script to enforce the versions defined in thepackage.json
sengines
field. Unfortunately, instead of installingcheck-engine
in ourdevDependencies
we instead were installingcheck-engines
(note the plural) errorneously. Because we're runningcheck-engine
before the dependencies are actually installed – the first time at least – we override npm 7's prompt to confirm installing a new package and so this typo was missed.check-engines
was never actually run, nor does it look like a security threat, so we don't need to do anything else, we just want to make sure we are using the correct major version ofcheck-engine
to avoid breaking changes in the future.