Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in preinstall script dependency #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivomurrell
Copy link
Contributor

We use the check-engine script to enforce the versions defined in the package.jsons engines field. Unfortunately, instead of installing check-engine in our devDependencies we instead were installing check-engines (note the plural) errorneously. Because we're running check-engine before the dependencies are actually installed – the first time at least – we override npm 7's prompt to confirm installing a new package and so this typo was missed. check-engines was never actually run, nor does it look like a security threat, so we don't need to do anything else, we just want to make sure we are using the correct major version of check-engine to avoid breaking changes in the future.

@ivomurrell ivomurrell requested a review from a team as a code owner December 1, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant