Skip to content

Commit

Permalink
Support Node.js 22
Browse files Browse the repository at this point in the history
Apps are moving to this, we should be running tests against it.
  • Loading branch information
rowanmanning committed Jan 21, 2025
1 parent 2ec447d commit 1f0ce1a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 5 deletions.
9 changes: 9 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ orbs:
tool-kit: financial-times/dotcom-tool-kit@5
executors:
node:
docker:
- image: cimg/node:22.13
node20_18:
docker:
- image: cimg/node:20.18
node18_20:
Expand Down Expand Up @@ -37,6 +40,7 @@ workflows:
parameters:
executor:
- node
- node20_18
- node18_20
requires:
- checkout
Expand All @@ -49,6 +53,7 @@ workflows:
parameters:
executor:
- node
- node20_18
- node18_20
requires:
- tool-kit/setup-<< matrix.executor >>
Expand All @@ -61,6 +66,7 @@ workflows:
parameters:
executor:
- node
- node20_18
- node18_20
requires:
- tool-kit/build-<< matrix.executor >>
Expand Down Expand Up @@ -94,6 +100,7 @@ workflows:
parameters:
executor:
- node
- node20_18
- node18_20
requires:
- checkout
Expand All @@ -103,6 +110,7 @@ workflows:
parameters:
executor:
- node
- node20_18
- node18_20
requires:
- tool-kit/setup-<< matrix.executor >>
Expand All @@ -112,6 +120,7 @@ workflows:
parameters:
executor:
- node
- node20_18
- node18_20
requires:
- tool-kit/build-<< matrix.executor >>
1 change: 1 addition & 0 deletions .toolkitrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ options:
plugins:
'@dotcom-tool-kit/circleci':
cimgNodeVersions:
- '22.13'
- '20.18'
- '18.20'
'@dotcom-tool-kit/doppler':
Expand Down
3 changes: 1 addition & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,12 @@
"n-express-generate-certificate": "bin/n-express-generate-certificate.sh"
},
"engines": {
"node": "18.x || 20.x",
"npm": "8.x || 9.x || 10.x"
"node": "18.x || 20.x || 22.x"
},
"config": {},
"false": {},
"volta": {
"node": "20.18.0"
"node": "22.13.0"
},
"husky": {
"hooks": {
Expand Down

0 comments on commit 1f0ce1a

Please sign in to comment.