Merge pull request #976 from Financial-Times/CPP-1368-fix-sticky-subs…

…cribe-button-tabindex fix(dotcom-ui-header): add negative tab index to sticky subscribe button
Financial-Times · Apr 4, 2023 · cedf521 · cedf521
2 parents a0cee4b + 8362fb3
commit cedf521
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/dotcom-ui-header/src/__test__/components/__snapshots__/StickyHeader.spec.tsx.snap b/packages/dotcom-ui-header/src/__test__/components/__snapshots__/StickyHeader.spec.tsx.snap
@@ -217,6 +217,7 @@ exports[`dotcom-ui-header/src/components/StickyHeader renders as a logged in use
             data-trackable="Subscribe"
             href="/products?segmentId=#"
             role="button"
+            tabIndex={-1}
           >
             Subscribe
           </a>

diff --git a/packages/dotcom-ui-header/src/components/sticky/partials.tsx b/packages/dotcom-ui-header/src/components/sticky/partials.tsx
@@ -131,7 +131,7 @@ const NavListRightLoggedInSticky = (props: THeaderProps) => {
       {!props.userIsSubscribed && subscribeAction && (
         <SubscribeButton
           item={subscribeAction}
-          variant={props.variant}
+          variant="sticky"
           className="o-header__top-button--hide-m"
         />
       )}