Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iterators to wirebson.Array and wirebson.Document #15

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Add iterators to wirebson.Array and wirebson.Document #15

merged 8 commits into from
Aug 6, 2024

Conversation

chilagrow
Copy link
Member

Closes #9.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Aug 5, 2024
@chilagrow chilagrow self-assigned this Aug 5, 2024
@chilagrow chilagrow marked this pull request as ready for review August 6, 2024 02:26
@chilagrow chilagrow requested a review from AlekSi as a code owner August 6, 2024 02:26
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup August 6, 2024 02:33
@AlekSi AlekSi enabled auto-merge (squash) August 6, 2024 06:19
wirebson/array_iter.go Outdated Show resolved Hide resolved
@AlekSi AlekSi merged commit c552f01 into main Aug 6, 2024
3 checks passed
@AlekSi AlekSi deleted the iter branch August 6, 2024 07:10
Comment on lines -122 to -126
// TODO https://github.com/FerretDB/wire/issues/9
func (doc *Document) Get(name string) any {
for _, f := range doc.fields {
if f.name == name {
return f.value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change should be reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add iterators and remove build tags
2 participants