Fix config #561
Fix config #561
Conversation
| @@ -87,8 +87,8 @@ results: | |||
| ferretdb: | |||
| stats: | |||
| expected_fail: 10 | |||
| expected_skip: 19 | |||
| expected_pass: 633 | |||
There was a problem hiding this comment.
Why the number of passing tests went down?
There was a problem hiding this comment.
That's needs some investigation.
There was a problem hiding this comment.
We seem to be running less subtests in total with the update. This is not the case for MongoDB. I am unsure why this is happening. I took a lot at the changelog but could not find a commit that might be the culprit. I logged some more output to verify that:
FerretDB:
CURRENT
commit: 6d814184973ae7ffc13281c93b423dc522a4bcca
Expectedly ignored: 16
Total number of tests: 678
UPDATE
commit: 6c7e1241b747d2fb5d164c9ca9d17617f33e7899
Expectedly ignored: 15
Total number of tests: 662
Any ideas?
There was a problem hiding this comment.
This bumped our passes back up a little.
| @@ -157,6 +155,8 @@ results: | |||
| - go.mongodb.org/mongo-driver/x/mongo/driver/integration/TestAggregate/Multiple_Batches | |||
| - go.mongodb.org/mongo-driver/x/mongo/driver/integration/TestAggregate/TestMaxTimeMSInGetMore | |||
| fail: | |||
| - go.mongodb.org/mongo-driver/mongo/integration/TestCausalConsistency_NotSupported | |||
There was a problem hiding this comment.
There must be a comment explaining why those tests fail
There was a problem hiding this comment.
I need to look into it more. They were previously passing now they panic.
=== RUN TestCausalConsistency_NotSupported
--- FAIL: TestCausalConsistency_NotSupported (0.08s)
go.mongodb.org/mongo-driver/mongo/integration/TestCausalConsistency_NotSupported/afterClusterTime_not_included:
=== RUN TestCausalConsistency_NotSupported/afterClusterTime_not_included
--- FAIL: TestCausalConsistency_NotSupported/afterClusterTime_not_included (0.08s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xe47b76]
goroutine 72 [running]:
testing.tRunner.func1.2({0xecf8e0, 0x17877e0})
/usr/local/go/src/testing/testing.go:1526 +0x372
testing.tRunner.func1()
/usr/local/go/src/testing/testing.go:1529 +0x650
panic({0xecf8e0, 0x17877e0})
/usr/local/go/src/runtime/panic.go:890 +0x263
go.mongodb.org/mongo-driver/mongo/integration.TestCausalConsistency_NotSupported.func1(0xc0002f0c40)
/home/byron/workdir/dance/tests/mongo-go-driver/mongo/integration/causal_consistency_test.go:225 +0x256
go.mongodb.org/mongo-driver/mongo/integration/mtest.(*T).RunOpts.func1(0x0?)
/home/byron/workdir/dance/tests/mongo-go-driver/mongo/integration/mtest/mongotest.go:266 +0x5a9
testing.tRunner(0xc0002fbba0, 0xc00003cde0)
/usr/local/go/src/testing/testing.go:1576 +0x217
created by testing.(*T).Run
/usr/local/go/src/testing/testing.go:1629 +0x806
There was a problem hiding this comment.
I am not super confident on this but it seems that the changes made now cause their event monitor to return nil here when it tries to inspect the command name. Could be related to mongodb/mongo-go-driver#1347?
@AlekSi should I add this failing test to common ignore for now?
There was a problem hiding this comment.
But it only fails on FerretDB which invalidates the above. 👁️
There was a problem hiding this comment.
@AlekSi should I add this failing test to common ignore for now?
Added to FerretDB failures.
Pull request was converted to draft
|
@b1ron this pull request has merge conflicts. |
Refs #556, #557.